[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

[Younan Zhang via Phabricator via cfe-commits]

zyounan marked an inline comment as done.
zyounan added a comment.

Thanks again for the review!



================
Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:28
+
+// expected-error@#1 {{no member named 'value' in 'is_convertible<bool, bool>'}}
+
----------------
erichkeane wrote:
> So I typically don't do the 'error' with a bookmark, just put the 'error' next to the line that causes the error, and bookmark the note.  It makes it easier to read.
Good suggestion!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158061/new/

https://reviews.llvm.org/D158061