[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D158540#4629042 <https://reviews.llvm.org/D158540#4629042>, @NoumanAmir657 wrote:

> Do you want the note to be like this:
>
>   ../llvm-test/x.cpp:5:1: note: virtual base class declared here
>       5 | struct Derived : virtual Base {
>         | ^
>   1 error generated.

Close! I was thinking more like:

  ../llvm-test/x.cpp:5:1: note: virtual base class declared here
      5 | struct Derived : virtual Base {
        |                          ^
  1 error generated.

(so the location points to the base class and not the derived class).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158540/new/

https://reviews.llvm.org/D158540