[PATCH] D159300: [AST] Support ConceptReference in DynTypedNode, add dump().

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 31 11:25:50 PDT 2023


sammccall created this revision.
sammccall added a reviewer: massberg.
Herald added a subscriber: kadircet.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added a project: clang.

The dump() is not actually included recursively in any other nodes' dump,
as this is too verbose (similar to NNS) but useful in its own right.

It's unfortunate to not have the actual tests yet, but the DynTypedNode
tests are matcher-based and adding matchers is a larger task than
DynTypedNode support (but can't be done first).

(I've got a clangd change stacked on this that uses DynTypedNode and
dump(), and both work. I'll send a change for matchers next).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D159300

Files:
  clang/include/clang/AST/ASTConcept.h
  clang/include/clang/AST/ASTFwd.h
  clang/include/clang/AST/ASTNodeTraverser.h
  clang/include/clang/AST/ASTTypeTraits.h
  clang/include/clang/AST/TextNodeDumper.h
  clang/lib/AST/ASTDumper.cpp
  clang/lib/AST/ASTTypeTraits.cpp
  clang/lib/AST/TextNodeDumper.cpp
  clang/unittests/AST/ASTTypeTraitsTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159300.555112.patch
Type: text/x-patch
Size: 7509 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230831/849c3200/attachment-0001.bin>


More information about the cfe-commits mailing list