[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

Thu Aug 31 09:18:28 PDT 2023

smeenai added a comment.

In D158475#4626856 <https://reviews.llvm.org/D158475#4626856>, @glandium wrote:

> In D158475#4626636 <https://reviews.llvm.org/D158475#4626636>, @smeenai wrote:
>
>> I'm halfway through an implementation of this, but I just realized that on Android, Clang never searches for C++ headers installed alongside the driver: https://github.com/llvm/llvm-project/blob/7af0eff5405bb88dc96c0b19892da0fbb44db433/clang/lib/Driver/ToolChains/Gnu.cpp#L3116-L3118. Are you using the C++ headers from the NDK but a library that you built locally, or are you manually specifying the path to your C++ headers?
>
> At the moment, we're only really using libunwind from the clang stdlib directory. So we don't really have the problem with headers. It will eventually be a problem when we get to use libc++, which we'll want at some point.

I decided to just fix the whole thing properly: D159292 <https://reviews.llvm.org/D159292> and D159293 <https://reviews.llvm.org/D159293>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158475/new/

https://reviews.llvm.org/D158475