[clang] e34ddb1 - [clang][ci] Don't block all jobs on clang-format

Louis Dionne via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 31 06:52:53 PDT 2023


Author: Louis Dionne
Date: 2023-08-31T09:52:41-04:00
New Revision: e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1

URL: https://github.com/llvm/llvm-project/commit/e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1
DIFF: https://github.com/llvm/llvm-project/commit/e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1.diff

LOG: [clang][ci] Don't block all jobs on clang-format

It was expressed in some reviews that Clang folks didn't want to hold
off other testing jobs in case clang-format failed. This patch makes
it so that the basic clang testing jobs will run even if clang-format
fails on the patch. The overall build will still be marked as failed,
but it will be possible to see the failures in clang tests so at least
there will be some feedback available.

The whole pipeline was originally blocked on clang-format because we
inherited that pipeline definition from libc++, where we want to block
on clang-format for capacity reasons.

Differential Revision: https://reviews.llvm.org/D159197

Added: 
    

Modified: 
    clang/utils/ci/buildkite-pipeline.yml

Removed: 
    


################################################################################
diff  --git a/clang/utils/ci/buildkite-pipeline.yml b/clang/utils/ci/buildkite-pipeline.yml
index 92793480217932..7a679176038c69 100644
--- a/clang/utils/ci/buildkite-pipeline.yml
+++ b/clang/utils/ci/buildkite-pipeline.yml
@@ -20,7 +20,6 @@ steps:
   - label: "Format"
     commands:
       - "clang/utils/ci/run-buildbot check-format"
-
     agents:
       queue: "linux"
     retry:
@@ -29,8 +28,6 @@ steps:
           limit: 2
     timeout_in_minutes: 120
 
-  - wait
-
   - label: "Building and testing clang (Linux)"
     commands:
       - "clang/utils/ci/run-buildbot build-clang"


        


More information about the cfe-commits mailing list