[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 31 04:36:43 PDT 2023
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:1059
- bool TraverseTypeConstraint(const TypeConstraint *TC) {
- // We want to handle all ConceptReferences but RAV is missing a
- // polymorphic Visit or Traverse method for it, so we handle
- // TypeConstraints specially here.
- Out(ReferenceLoc{TC->getNestedNameSpecifierLoc(),
- TC->getConceptNameLoc(),
+ bool TraverseConceptReference(ConceptReference *ConceptRef) {
+ Out(ReferenceLoc{ConceptRef->getNestedNameSpecifierLoc(),
----------------
I think this can just be VisitConceptReference, then no need to call into base
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159268/new/
https://reviews.llvm.org/D159268
More information about the cfe-commits
mailing list