[PATCH] D157485: [X86][RFC] Support new feature AVX10

Thu Aug 31 00:00:12 PDT 2023

pengfei planned changes to this revision.
pengfei added a comment.

In D157485#4597603 <https://reviews.llvm.org/D157485#4597603>, @e-kud wrote:

> Just curious, in RFC we have `-mavx10.x-256/-mavx10.x-512` but here we refer to `-mavx10.x/-mavx10.x,-mavx10-512bit`. Is it compliant with GCC, or the revision is just for the illustrative purpose?

Sorry for the late reply. We have received a couple concerns about how to interpret these options, especially when used together with AVX512 options. We decided not to provide AVX10.1 options at the present, instead, we just provide `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features. For more details, lease take a look at D159250 <https://reviews.llvm.org/D159250>.

================
Comment at: clang/lib/Basic/Targets/X86.cpp:739
+  if (HasAVX10_512BIT)
+    Builder.defineMacro("__AVX10_512BIT__");
+
----------------
MaskRay wrote:
> This is untested?
Done in an alternative reversion D159250.

================
Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:261
+        if (AVXVecSize == 256)
+          D.Diag(diag::warn_drv_overriding_flag_option) << "AVX10-256"
+                                                        << "AVX10-512";
----------------
MaskRay wrote:
> `warn_drv_overriding_flag_option` is under the group `-Woverriding-t-option`, which was intended for clang-cl `/T*` options (`D1290`).
> 
> I created D158137 to add `-Woverriding-option`.
Thanks! This is not needed in the new version.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157485/new/

https://reviews.llvm.org/D157485