[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 14:03:42 PDT 2023


MaskRay added a comment.

In D159054#4628278 <https://reviews.llvm.org/D159054#4628278>, @probinson wrote:

> In D159054#4626772 <https://reviews.llvm.org/D159054#4626772>, @brad wrote:
>
>> Just FYI I am not in a rush to commit this. I am posting this more so as a means of prodding for discussion of the feature.
>
> So far nobody has popped up to say they want it.
>
> @MaskRay I poked around a bit on sourcegraph.com and didn't see any statement about what it actually searches, other than vague "all your repositories" and "all your code." The "your" bit makes me wonder how broad it is really. The website doesn't say.

They index quite a lot: https://about.sourcegraph.com/blog/indexing-the-oss-universe-update-more-code-hosts

I also tried using my company's internal code search and I cannot find environment variables using `C_INCLUDE_DIRS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159054/new/

https://reviews.llvm.org/D159054



More information about the cfe-commits mailing list