[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Soumi Manna via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 12:56:06 PDT 2023


Manna marked an inline comment as done.
Manna added inline comments.


================
Comment at: clang/lib/Lex/PPDirectives.cpp:494-495
   ++NumSkipped;
   assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?");
+  assert(CurLexer && "Invalid lexer value");
 
----------------
tahonermann wrote:
> Would you mind splitting out all of the predicates? The updates to the messages in the suggested edit are intended to match the style present in other similar assertions.
Thanks @tahonermann for the suggestion. Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158293/new/

https://reviews.llvm.org/D158293



More information about the cfe-commits mailing list