[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference
Tom Honermann via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 30 12:47:57 PDT 2023
tahonermann added inline comments.
================
Comment at: clang/lib/Lex/PPDirectives.cpp:494-495
++NumSkipped;
assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?");
+ assert(CurLexer && "Invalid lexer value");
----------------
Would you mind splitting out all of the predicates? The updates to the messages in the suggested edit are intended to match the style present in other similar assertions.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158293/new/
https://reviews.llvm.org/D158293
More information about the cfe-commits
mailing list