[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 07:52:56 PDT 2023


arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:2035
+
+  FuncAttr.addAttribute("target-features", llvm::join(MergedFeatures, ","));
+}
----------------
do you need to guard against adding the empty attribute? I don't want to see "target-features"=""


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159206/new/

https://reviews.llvm.org/D159206



More information about the cfe-commits mailing list