[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 06:23:18 PDT 2023


ldionne created this revision.
ldionne added a reviewer: aaron.ballman.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

It was expressed in some reviews that Clang folks didn't want to hold
off other testing jobs in case clang-format failed. This patch makes
it so that the basic clang testing jobs will run even if clang-format
fails on the patch. The overall build will still be marked as failed,
but it will be possible to see the failures in clang tests so at least
there will be some feedback available.

The whole pipeline was originally blocked on clang-format because we
inherited that pipeline definition from libc++, where we want to block
on clang-format for capacity reasons.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D159197

Files:
  clang/utils/ci/buildkite-pipeline.yml


Index: clang/utils/ci/buildkite-pipeline.yml
===================================================================
--- clang/utils/ci/buildkite-pipeline.yml
+++ clang/utils/ci/buildkite-pipeline.yml
@@ -20,7 +20,6 @@
   - label: "Format"
     commands:
       - "clang/utils/ci/run-buildbot check-format"
-
     agents:
       queue: "linux"
     retry:
@@ -29,8 +28,6 @@
           limit: 2
     timeout_in_minutes: 120
 
-  - wait
-
   - label: "Building and testing clang (Linux)"
     commands:
       - "clang/utils/ci/run-buildbot build-clang"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159197.554692.patch
Type: text/x-patch
Size: 548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230830/4823d868/attachment.bin>


More information about the cfe-commits mailing list