[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

Wed Aug 30 05:16:39 PDT 2023

mstorsjo added inline comments.

================
Comment at: openmp/runtime/test/target/target_thread_limit.cpp:28
+// OMP51: target: parallel
+// OMP51: target: parallel
+// OMP51-NOT: target: parallel
----------------
This test fails when running (on Windows) on GitHub Actions runners - see https://github.com/mstorsjo/llvm-mingw/actions/runs/6019088705/job/16342540379.

I believe that this bit of the test has got a hidden assumption that it is running in an environment with 4 or more cores. By setting `#pragma omp target thread_limit(tl)` (with `tl=4`) and running a line in parallel with `#pragma omp parallel`, it expects that we'll get 4 printouts - while in practice, we'll get anywhere between 1 and 4 printouts depending on the number of cores.

Is there something that can be done to make this test work in such an environment too?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152054/new/

https://reviews.llvm.org/D152054