[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 01:21:21 PDT 2023


mstorsjo added a comment.

In D152752#4626234 <https://reviews.llvm.org/D152752#4626234>, @rnk wrote:

> I need to get to it, my recollection is that @mstorsjo ran into the same issue here for mingw and made some changes, I wanted to go dig those up as a starting point. I may have completely forgotten things though.

Hmm, I don't remember doing anything in that area - I don't think I've had to touch variadics on i386 (or x86_64 for that matter) so far, or anything relating to aligned variadics. (The main thing that might sound similar to alignment was about setting up the homed registers on aarch64 when receiving variadics; there's some special casing there relating to whether the number of homed registers is even or odd. But all of that is much deeper within lowering in LLVM.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152752/new/

https://reviews.llvm.org/D152752



More information about the cfe-commits mailing list