[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

Kai Luo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 22:57:32 PDT 2023


lkail created this revision.
lkail added reviewers: lhames, v.g.vassilev.
Herald added a project: All.
lkail requested review of this revision.
Herald added subscribers: cfe-commits, wangpc.
Herald added a project: clang.

In Orc runtime, we use `dlopen(nullptr, ...)` to open current executable, this requires `-rdynamic` flag.

As `llvm/CMakeLists.txt` suggests

  # Make sure we don't get -rdynamic in every binary. For those that need it,
  # use export_executable_symbols(target).

This patch exports symbols in `ClangReplInterpreterExceptionTests`. This also fixes `ClangReplInterpreterExceptionTests` is skipped on ppc64 when jitlink is used.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D159167

Files:
  clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt


Index: clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt
===================================================================
--- clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt
+++ clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt
@@ -22,3 +22,5 @@
   clangFrontend
   )
 add_dependencies(ClangReplInterpreterExceptionTests clang-resource-headers)
+
+export_executable_symbols(ClangReplInterpreterExceptionTests)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159167.554574.patch
Type: text/x-patch
Size: 439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230830/2b7d351a/attachment.bin>


More information about the cfe-commits mailing list