[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/docs/UsersManual.rst:3161
+static storage duration, including static data members of classes and
+block-scope static variables will be marked with the toc-data attribute.
+Alternatively, the user can specify a comma separated list of external linkage
----------------
The "toc-data attribute" is an implementation detail. The user-facing documentation should not talk about it.


================
Comment at: clang/docs/UsersManual.rst:3173
+which variables will be an exception to -mno-tocdata. Alternatively, a user
+may specify -mtocdata to mark all suitable variables with toc-data and specify
+-mno-tocdata=<list> to add which variables will be an exception to -mtocdata.
----------------
Please document the conditions for a variable to be "suitable".


================
Comment at: clang/docs/UsersManual.rst:3178
+
+  Mark all external linkage variables and variables with static storage duration
+  that are not explicitly specified with -mno-tocdata= as toc-data.
----------------
The use of "all" is incorrect. Please qualify with "suitable" (and address this issue elsewhere in the text where applicable).


================
Comment at: clang/docs/UsersManual.rst:3159
 
+Mark TOC Data / Not TOC Data (AIX-specific)
+-------------------------------------------
----------------
amyk wrote:
> 
@syzaara, I see the comment has been addressed but it is not marked as "done". The author is responsible for marking comments as "done" in Phabricator. Please mark all comments that you believe have been addressed as "done" so that other parties know if the comment is still pending action.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153907/new/

https://reviews.llvm.org/D153907