[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

Tue Aug 29 16:06:15 PDT 2023

smeenai added a comment.

In D158475#4623852 <https://reviews.llvm.org/D158475#4623852>, @glandium wrote:

> In D158475#4623842 <https://reviews.llvm.org/D158475#4623842>, @smeenai wrote:
>
>> In D158475#4623471 <https://reviews.llvm.org/D158475#4623471>, @glandium wrote:
>>
>>> This conflicts with D146664 <https://reviews.llvm.org/D146664>
>>
>> It sounds like you want the same logic as D158476 <https://reviews.llvm.org/D158476> to apply to the stdlib search as well as the runtimes search, right?
>
> Sounds about right.
>
>> I can make both be consistent.
>
> That would be much appreciated.

I'm halfway through an implementation of this, but I just realized that on Android, Clang never searches for C++ headers installed alongside the driver: https://github.com/llvm/llvm-project/blob/7af0eff5405bb88dc96c0b19892da0fbb44db433/clang/lib/Driver/ToolChains/Gnu.cpp#L3116-L3118. Are you using the C++ headers from the NDK but a library that you built locally, or are you manually specifying the path to your C++ headers?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158475/new/

https://reviews.llvm.org/D158475