[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

[Richard Smith via cfe-commits]

On Tue, 22 Aug 2023 at 12:43, Nouman Amir via Phabricator via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Index: clang/include/clang/Basic/DiagnosticSemaKinds.td
> ===================================================================
> --- clang/include/clang/Basic/DiagnosticSemaKinds.td
> +++ clang/include/clang/Basic/DiagnosticSemaKinds.td
> @@ -9393,8 +9393,7 @@
>    "the parameter for an explicitly-defaulted copy assignment operator
> must be an "
>    "lvalue reference type">;
>  def err_incorrect_defaulted_constexpr : Error<
> -  "defaulted definition of %sub{select_special_member_kind}0 "
> -  "is not constexpr">;
> +  "%sub{select_special_member_kind}0 cannot be 'constexpr' in a class or
> struct with virtual base classes">;
>

Please don't say "class or struct" here. Either just say "class" (a struct
is a kind of class) or actually figure out which one it is and say that.


>  def err_incorrect_defaulted_consteval : Error<
>    "defaulted declaration of %sub{select_special_member_kind}0 "
>    "cannot be consteval because implicit definition is not constexpr">;
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230829/68b01fd9/attachment-0001.html>