[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 14:21:51 PDT 2023


beanz added a comment.

Yea, the gist of it is that in HLSL `this` is a reference not a pointer, which means the `CXXThisExpr` is always an LValue.

I think the right fix for this is to cleanup the `CXXThisExpr` creation code and create a `CXXThisExpr::Create` method like the other AST nodes. Then I can have a simpler way to force the `CXXThisExpr` to always be an LValue for HLSL.

@aaron.ballman, does that sound reasonable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159126/new/

https://reviews.llvm.org/D159126



More information about the cfe-commits mailing list