[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 13:28:11 PDT 2023


tra added a comment.

In D158778#4626181 <https://reviews.llvm.org/D158778#4626181>, @jhuber6 wrote:

> Just doing a simple example here https://godbolt.org/z/Y3E58PKMz shows that for NVPTX we error out (as I would expect) but for AMDGPU we emit an x86 80-bit double.

With this patch NVPTX will behave the same as AMDGPU and we'll no longer error out.

I think I may need to explicitly add a diagnostics for the case where the host idea of long double and __float128 does not match that of the target. It would have to be specific to OpenMP, as CUDA does expect this discrepancy for historic reasons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158778/new/

https://reviews.llvm.org/D158778



More information about the cfe-commits mailing list