[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 13:18:36 PDT 2023


sammccall added a comment.

In D158872#4626095 <https://reviews.llvm.org/D158872#4626095>, @aaron.ballman wrote:

> Out of curiosity, are you testing on Windows with MSVC? My understanding on build time performance impacts was that it's debug builds with MSVC that get hit especially hard. (I can test that setup but I could use some help figuring out how you tested compile times so I can do a similar test instead of something totally different from what you tried.)

I'm not :-( I don't have a windows machine, and the VM I used to have has bitrotted beyond repair (not sure how useful benchmarks from there would be anyway).

This is with clang on linux, just running `time clang-check-14 include/clang/ASTMatchers/ASTMatchers.h` a few times.
The "deps only" test was `#if 0` ing out all the code in `ASTMatcher.h`, and commenting out the `ASTMatchers/*` includes, and repeating the same.
For object files I just added a dummy `ASTMatchers.cpp` with only `#include "clang/ASTMatchers/ASTMatchers.h"`.

I guess the equivalent of clang-check would be `/Zs`, not sure the best way to feed it the right flags...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158872/new/

https://reviews.llvm.org/D158872



More information about the cfe-commits mailing list