[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

Lang Hames via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 08:59:30 PDT 2023


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Otherwise LGTM!



================
Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:96-100
+  JITDylibSearchOrder O;
+  JITDylibLookupFlags Flags = JITDylibLookupFlags::MatchExportedSymbolsOnly;
+  O.push_back({&Jit->getMainJITDylib(), Flags});
+  O.push_back({Jit->getPlatformJITDylib().get(), Flags});
+  O.push_back({Jit->getProcessSymbolsJITDylib().get(), Flags});
----------------
I think this should be equivalent to
```
auto SO =
  makeJITDylibSearchFlags(&Jit->getMainJITDylib(),
                          Jit->getPlatformJITDylib().get(),
                          Jit->getProcessSymbolsJITDylib.get());
```
but this is purely cosmetic -- either way works.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159115/new/

https://reviews.llvm.org/D159115



More information about the cfe-commits mailing list