[PATCH] D155858: Add a concept AST node.

Jens Massberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 04:18:58 PDT 2023


massberg updated this revision to Diff 554257.
massberg marked 7 inline comments as done.
massberg added a comment.

Resolve more of the open comments.

- add `getBeginLoc()`, `getEndLoc()` and `getSourceRange()` to `ConceptReference` and updated corresponding functions in `ConceptSpecializationExpr`
- additional fixed `getBeginLoc()` to work correctly with empty argument lists
- remove `const` from parameters of `TraverseConceptReference()` and `VisitConceptReference()`

still missing:

- Add tests for new location functions
- Investigation why we have to create a `ConceptReference` in `initializeLocal()` which looks not right
- Update patch description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155858/new/

https://reviews.llvm.org/D155858

Files:
  clang/include/clang/AST/ASTConcept.h
  clang/include/clang/AST/DeclTemplate.h
  clang/include/clang/AST/ExprConcepts.h
  clang/include/clang/AST/RecursiveASTVisitor.h
  clang/include/clang/AST/TypeLoc.h
  clang/include/clang/Serialization/ASTRecordReader.h
  clang/include/clang/Serialization/ASTRecordWriter.h
  clang/lib/AST/ASTContext.cpp
  clang/lib/AST/ASTImporter.cpp
  clang/lib/AST/DeclTemplate.cpp
  clang/lib/AST/ExprConcepts.cpp
  clang/lib/AST/TypeLoc.cpp
  clang/lib/Sema/SemaTemplate.cpp
  clang/lib/Sema/SemaTemplateInstantiate.cpp
  clang/lib/Sema/SemaType.cpp
  clang/lib/Sema/TreeTransform.h
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTReaderDecl.cpp
  clang/lib/Serialization/ASTReaderStmt.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/lib/Serialization/ASTWriterDecl.cpp
  clang/lib/Serialization/ASTWriterStmt.cpp
  clang/unittests/Tooling/RecursiveASTVisitorTests/Concept.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155858.554257.patch
Type: text/x-patch
Size: 54664 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230829/4027c3ca/attachment-0001.bin>


More information about the cfe-commits mailing list