[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

[Simon Tatham via Phabricator via cfe-commits]

simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.

The change LGTM, and "agree with gcc" seems like a reasonable justification in this case.

But I'm curious more generally about what options should / shouldn't be covered by `-Wunused-command-line-argument`. Doesn't the same reasoning apply to //most// options that C compilation uses and assembly doesn't? If you have a command of the form `clang -someoption -c foo.c`, it's surely //always// convenient for a user to be able to change the `.c` into a `.s`, or to put a variable list of files on the end of the command line which might or might not include any `.c` files. Why is this option in particular different from others? Is there a documented policy anywhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158688/new/

https://reviews.llvm.org/D158688