[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 20:36:50 PDT 2023


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Technically there is some risk but I think the blast radius, if present, is extremely small.

`C_INCLUDE_DIRS` is not recognized by GCC.

If I use https://sourcegraph.com/search?q=context:global+%5CbC_INCLUDE_DIRS%3D+-f:clang/&patternType=regexp&case=yes&sm=1&groupBy=repo to find the use cases, one project has a use like add_opt C_INCLUDE_DIRS=$C_INCLUDES, but the search patch seems likely redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159054/new/

https://reviews.llvm.org/D159054



More information about the cfe-commits mailing list