[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers
Ding Fei via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 28 17:29:24 PDT 2023
danix800 added a comment.
In D158872#4622124 <https://reviews.llvm.org/D158872#4622124>, @aaron.ballman wrote:
> Are these matchers going to be used in-tree (by clang-tidy, or something else)? We typically do not add new AST matches until there's a need for them because the AST matchers have a pretty big impact on build times of Clang itself.
They are used in `ASTImporter` testcases as shown in https://reviews.llvm.org/D158948. Though this might not be a strong reason to
add these matchers and bring on too much bad impact.
ASTImporter is more urgent since we still lack support for some of the AST nodes so I considered adding them batchly and started with
type-related nodes. I thought that matchers're OK to use in unittests as actually they are used a lot there, but I wasn't aware of the impact
on build of Clang.
If not acceptable, I'm OK with it. We can still test importing with other ways. Matchers are not mandatory.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158872/new/
https://reviews.llvm.org/D158872
More information about the cfe-commits
mailing list