[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 15:56:25 PDT 2023


tra added a subscriber: ABataev.
tra added a comment.

@ABataev

This patch breaks breaks two tests:

- github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_codegen.cpp
- github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_messages.cpp

It's not clear what exactly these tests are testing for and I can't tell whether I should just remove the checks related to `__float128`, or if there's something else that would need to be done on the OpenMP side.

AFAICT, OpenMP will pick up `double` format for `__float128` after my patch. This suggests that we would only have `long double` left as an unsupported type on GPU-supporting targets, which suggests that I should just remove the checks related to `__float128` from those tests.

Am I missing something? Is there anything else that may need to be done on the OpenMP side?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158778/new/

https://reviews.llvm.org/D158778



More information about the cfe-commits mailing list