[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 12:16:18 PDT 2023


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:121
                                const ArgList &Args,
-                               std::vector<StringRef> &Features) {
+                               std::vector<StringRef> &Features, bool ForAS) {
+  if (ForAS) {
----------------
Note: ClangAs::ConstructJob doesn't call `Clang::RenderTargetOptions` (and can't as the function is in `Clang::`). `bool ForAS` is a workaround used by ARM and will also be used by AArch64. I plan to clean this up at some point, but for release/17.x I intentionally make it simple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159010/new/

https://reviews.llvm.org/D159010



More information about the cfe-commits mailing list