[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 11:11:48 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D158709#4622006 <https://reviews.llvm.org/D158709#4622006>, @iana wrote:

> In D158709#4621199 <https://reviews.llvm.org/D158709#4621199>, @aaron.ballman wrote:
>
>> At a high-level (not just for this patch, but for the entire series): is this need specific to your downstream or is this a more general need? e.g., should this complexity be kept downstream until we've got a second platform needing it?
>
> I think it's a general need to properly modularize the clang headers, I don't think it's really Apple specific.

Good to know (that was my understanding as well). I'd say let's move forward with this approach given there's not a clearly better way to go about this. LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158709/new/

https://reviews.llvm.org/D158709



More information about the cfe-commits mailing list