[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.
Jennifer Yu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 28 09:12:38 PDT 2023
jyu2 added a comment.
Ping,
Our customer fond problem I submit bug: in https://github.com/llvm/llvm-project/issues/65045
This issue related with big change of 5179eb78210a2ad01a18c37b75048ccfe78414ac
Where internal linkage for inheriting ctor were set in change set at following code. Could some one help to code review the change? Or any suggestion on how to fix this in other ways?
Thank you so much for the help.
Jennifer
CodeGenModule.cpp
if (isa<CXXConstructorDecl>(D) &&
cast<CXXConstructorDecl>(D)->isInheritingConstructor() &&
Context.getTargetInfo().getCXXABI().isMicrosoft()) {
// Our approach to inheriting constructors is fundamentally different from
// that used by the MS ABI, so keep our inheriting constructor thunks
// internal rather than trying to pick an unambiguous mangling for them.
return llvm::GlobalValue::InternalLinkage;
}
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158538/new/
https://reviews.llvm.org/D158538
More information about the cfe-commits
mailing list