[PATCH] D158953: [analyzer] MmapWriteExecChecker: use getAs instead of castAs

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 27 10:00:37 PDT 2023


steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

Land it, whenever you wish. Thanks!
PS: usually we don't have a comment like that. The name of the function should give enough context, along with a // no-crash comment at the line where it was triggered in the past.
That usually just helps reviewers to understand the issue, but as I triaged this I'm aware what's going on.
In tricky situations.
I just let you know about these conventions, no need to adjust this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158953/new/

https://reviews.llvm.org/D158953



More information about the cfe-commits mailing list