[clang-tools-extra] 26078f3 - [clang-tidy][NFC] Fix cppcoreguidelines-missing-std-forward findings
Piotr Zegar via cfe-commits
cfe-commits at lists.llvm.org
Sun Aug 27 05:00:05 PDT 2023
Author: Piotr Zegar
Date: 2023-08-27T11:59:03Z
New Revision: 26078f33bdfa30f35bb880feb0c088b8bd2169c8
URL: https://github.com/llvm/llvm-project/commit/26078f33bdfa30f35bb880feb0c088b8bd2169c8
DIFF: https://github.com/llvm/llvm-project/commit/26078f33bdfa30f35bb880feb0c088b8bd2169c8.diff
LOG: [clang-tidy][NFC] Fix cppcoreguidelines-missing-std-forward findings
Fix issues found by clang-tidy in clang-tidy source directory.
Added:
Modified:
clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp
Removed:
################################################################################
diff --git a/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
index e2c2dad6cf323e..7b02576a6093cb 100644
--- a/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
@@ -479,7 +479,7 @@ struct MixData {
return *this;
}
- template <class F> MixData withCommonTypeTransformed(F &&Func) const {
+ template <typename F> MixData withCommonTypeTransformed(const F &Func) const {
if (CommonType.isNull())
return *this;
diff --git a/clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp b/clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
index 7af096053e9e27..855c4a2efc373e 100644
--- a/clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
+++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
@@ -31,7 +31,7 @@ AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) {
// Iterate over all the fields in a record type, both direct and indirect (e.g.
// if the record contains an anonymous struct).
template <typename T, typename Func>
-void forEachField(const RecordDecl &Record, const T &Fields, Func &&Fn) {
+void forEachField(const RecordDecl &Record, const T &Fields, const Func &Fn) {
for (const FieldDecl *F : Fields) {
if (F->isAnonymousStructOrUnion()) {
if (const CXXRecordDecl *R = F->getType()->getAsCXXRecordDecl())
@@ -44,7 +44,7 @@ void forEachField(const RecordDecl &Record, const T &Fields, Func &&Fn) {
template <typename T, typename Func>
void forEachFieldWithFilter(const RecordDecl &Record, const T &Fields,
- bool &AnyMemberHasInitPerUnion, Func &&Fn) {
+ bool &AnyMemberHasInitPerUnion, const Func &Fn) {
for (const FieldDecl *F : Fields) {
if (F->isAnonymousStructOrUnion()) {
if (const CXXRecordDecl *R = F->getType()->getAsCXXRecordDecl()) {
diff --git a/clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp b/clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp
index a67b1cdc81f987..ccaa686f853234 100644
--- a/clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp
@@ -136,7 +136,7 @@ getRepresentation(const std::vector<llvm::StringRef> &Config,
template <typename T>
static bool isAnyOperatorEnabled(const std::vector<llvm::StringRef> &Config,
- T &&Operators) {
+ const T &Operators) {
for (const auto &[traditional, alternative] : Operators) {
if (!getRepresentation(Config, traditional, alternative).empty())
return true;
More information about the cfe-commits
mailing list