[clang-tools-extra] 44b38fe - [clang-tidy][NFC] Fix bugprone-implicit-widening-of-multiplication-result findings

Piotr Zegar via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 27 01:53:56 PDT 2023


Author: Piotr Zegar
Date: 2023-08-27T08:52:11Z
New Revision: 44b38fe86e9e74ebd0e6de9583e6456313d564ac

URL: https://github.com/llvm/llvm-project/commit/44b38fe86e9e74ebd0e6de9583e6456313d564ac
DIFF: https://github.com/llvm/llvm-project/commit/44b38fe86e9e74ebd0e6de9583e6456313d564ac.diff

LOG: [clang-tidy][NFC] Fix bugprone-implicit-widening-of-multiplication-result findings

Fix issues found by clang-tidy in clang-tidy source directory.

Added: 
    

Modified: 
    clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp b/clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp
index 0b7887ecfdfac6..c3b47d41c46d64 100644
--- a/clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp
+++ b/clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp
@@ -27,10 +27,10 @@ CharUnits
 StructPackAlignCheck::computeRecommendedAlignment(CharUnits MinByteSize) const {
   CharUnits NewAlign = CharUnits::fromQuantity(1);
   if (!MinByteSize.isPowerOfTwo()) {
-    int MSB = (int)MinByteSize.getQuantity();
+    CharUnits::QuantityType MSB = MinByteSize.getQuantity();
     for (; MSB > 0; MSB /= 2) {
-      NewAlign = NewAlign.alignTo(
-          CharUnits::fromQuantity(((int)NewAlign.getQuantity()) * 2));
+      NewAlign =
+          NewAlign.alignTo(CharUnits::fromQuantity(NewAlign.getQuantity() * 2));
       // Abort if the computed alignment meets the maximum configured alignment.
       if (NewAlign.getQuantity() >= MaxConfiguredAlignment)
         break;


        


More information about the cfe-commits mailing list