[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

Aditya Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 26 08:43:13 PDT 2023


hiraditya added a comment.

> I'm marking as requiring changes mostly for the latter comment about CLANG_INCLUDE_TESTS.

Added CLANG_INCLUDE_TESTS to the conditional. btw when CLANG_INCLUDE_TESTS is OFF, `ninja check-clang-tools` target doesn't get created so adding CLANG_INCLUDE_TESTS here didn't seem necessary, although tbh i'm not too familiar with the build system.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158566/new/

https://reviews.llvm.org/D158566



More information about the cfe-commits mailing list