[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 25 16:14:24 PDT 2023


owenpan added inline comments.


================
Comment at: clang/lib/Format/WhitespaceManager.cpp:1247
         if (Previous && Previous->isNot(TT_LineComment)) {
-          Changes[Next->Index].Spaces = 0;
+          Changes[Next->Index].Spaces = BracePadding;
           Changes[Next->Index].NewlinesBefore = 0;
----------------
owenpan wrote:
> Can we assert that `Spaces == 0`? If not, we should add a test case.
We can't assert that, but setting `Spaces` here seems superfluous as it's set correctly below anyways?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158795/new/

https://reviews.llvm.org/D158795



More information about the cfe-commits mailing list