[PATCH] D151575: [clang][diagnostics] Always show include stacks on top-level diagnostics

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

> Maybe we should consider adding a flag to set diagnostic verbosity level? e.g., -fdiagnostic-verbosity=terse|default|verbose where terse never prints notes or include stacks, default is what we do today, and verbose always prints include stacks?

My guess would be that not enough people would discover and use it, so we shouldn't do that.

I guess a basic question: what does GCC do about these "included from" stacks compared to clang?

Also it seemed like on the bug there was a more narrower issue being discussed - that the notes were missing from a second error because it had the same include stack as a note attached to a previous error, but not the same include stack as the previous error (which is the last thing with the include stack mentioned)? I may've missed the point where it generalized from that particular bug to "let's put the include stack always instead" rather than addressing that mismatch of looking at the last message in general, rather than the last non-note message (I guess the include stack is only printed for non-notes, by the looks of the bug example? So those are the ones that should be cached/checked against)

But equally, I suspect it's probably OK to do it unconditionally... probably.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151575/new/

https://reviews.llvm.org/D151575