[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 25 13:38:23 PDT 2023


sammccall added a comment.

I think we're not *that* far away from landing the AST change, and changing RecursiveASTVisitor now is probably confusing and not worth the churn.
So I'd prefer to wait for now...



================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:240
+
+  bool TraverseConceptReference(const ConceptReference &C) {
+    report(C.getConceptNameLoc(), C.getFoundDecl());
----------------
after D155858 this can be VisitConceptReference


================
Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:217
+    void $2^func2() requires $Bar4^Bar<T> {}
+  )cpp");
+  Inputs.Code = Code.code();
----------------
to complete the set I think you want

`void foo(Bar auto x)` (abbreviated template param) and `Bar auto x = 1` (deduced type).

Though these may not pass yet


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158842/new/

https://reviews.llvm.org/D158842



More information about the cfe-commits mailing list