[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

Bryan Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 25 09:47:02 PDT 2023


bryanpkc added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:821
 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group<Link_Group>,
+    Visibility<[ClangOption, FlangOption]>,
     MetaVarName<"<dir>">, HelpText<"Add directory to library search path">;
----------------
erjin wrote:
> bryanpkc wrote:
> > Question: How does Clang not give an error for `-L` if this wasn't visible to Clang?
> If there is no Visibility specified, the default Visibility is the ClangOption. If we want to add an extra option, the visibility needs both.
Thanks for the explanation!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158763/new/

https://reviews.llvm.org/D158763



More information about the cfe-commits mailing list