[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

Ding Fei via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 25 09:27:01 PDT 2023


danix800 added a comment.

In D158813#4616816 <https://reviews.llvm.org/D158813#4616816>, @steakhal wrote:

> Let me try to summarize some of the variables:
>
> So, given an invocation like `MPI_Waitall(C, Requests, Statues)`:
>
> - `MR` is `lval(Requests)`
> - `ElementCount` is the number of elements `Requests` consist of.
> - `ArrSize` is basically `ElementCount` but an APSInt.
> - `MROffset` is the offset and allocated region of the `Requests` region.
> - `Index` is ConcreteInt(0, ..., ArrSize)
> - `Count` is `C`, which is likely a ConcreteInt.
>
> Please note that I have no idea what this checker does.

It's really messy. I tried to refactor and clarify intentions with better naming. Thanks for the summary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158813/new/

https://reviews.llvm.org/D158813



More information about the cfe-commits mailing list