[PATCH] D158591: Add support of Windows Trace Logging macros

Richard Dzenis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 25 05:12:11 PDT 2023


RIscRIpt added a comment.

In D158591#4616728 <https://reviews.llvm.org/D158591#4616728>, @RIscRIpt wrote:

> And it seems that `BasePtr` points to a different object, not the one which corresponds to StringLiteral (at step 2).

If I understand everything correctly, then in visitGlobalInitializer <https://github.com/llvm/llvm-project/blob/6dfe55569d88ff654d13e6c09267eff0cd9c9f0d/clang/lib/AST/Interp/ByteCodeExprGen.h#L177-L181>, when we return from `visitInitializer` our `this->Locals` becomes empty. So `this->emitCheckGlobalCtor(Init)` fails, because it sees are elements are uninitialized.

Thanks for approval! Let me know if I should report my observations about new constexpr interpreter somewhere else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158591/new/

https://reviews.llvm.org/D158591



More information about the cfe-commits mailing list