[PATCH] D154382: [ClangRepl] support code completion at a REPL

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 25 01:57:08 PDT 2023


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:845
   case CodeCompletionContext::CCC_NewName:
+  case CodeCompletionContext::CCC_TopLevelOrExpression:
     return false;
----------------
This should be `true` rather than `false`, since both TopLevel and Expression are completed using the index.

(Though I realize that for now we'll never hit this context)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154382/new/

https://reviews.llvm.org/D154382



More information about the cfe-commits mailing list