[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

[Han Shen via Phabricator via cfe-commits]

shenhan added inline comments.


================
Comment at: clang/test/Driver/fsplit-machine-functions.c:19
+// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | FileCheck %s --check-prefix=ERR2
+// ERR2: clang: error: unsupported option '-fsplit-machine-functions' for target
+
----------------
MaskRay wrote:
> We should not test `clang: ` before `error:`. It may be a different string in certain builds where `%clang` is a symlink to a file not named `clang`. This would also fail on Windows. Rule of thumb: don't test the exact string before `error:`
Acked.


================
Comment at: clang/test/Driver/fsplit-machine-functions.c:21
+
+// The following all run successfully.
+// RUN: %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions -Xarch_device -fno-split-machine-functions %s
----------------
MaskRay wrote:
> We don't really need new tests. The existing `--target=arm-unknown-linux` one I added is sufficient.
Done, removed newly added cases.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158755/new/

https://reviews.llvm.org/D158755