[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:501
   if (CGF.Builder.getIsFPConstrained()) {
     CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E);
     Function *F = CGF.CGM.getIntrinsic(ConstrainedIntrinsicID, Src0->getType());
----------------
rjmccall wrote:
> Is this existing condition not good enough, and why?
It's only in the strictfp branch for some reason, I don't think both would be needed


================
Comment at: clang/test/CodeGen/fp-contract-fast-pragma.cpp:2
 // RUN: %clang_cc1 -O3 -triple %itanium_abi_triple -emit-llvm -o - %s | FileCheck %s
 
 // Is FP_CONTRACT honored in a simple case?
----------------
Should also check constrained run line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158695/new/

https://reviews.llvm.org/D158695