[PATCH] D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator
Félix-Antoine Constantin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 23 18:46:06 PDT 2023
felix642 created this revision.
Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun.
Herald added a project: All.
felix642 requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D158691
Files:
clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp
Index: clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp
===================================================================
--- clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp
+++ clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp
@@ -1,4 +1,4 @@
-// RUN: %check_clang_tidy %s readability-container-size-empty %t -- \
+// RUN: %check_clang_tidy -std=c++14-or-later %s readability-container-size-empty %t -- \
// RUN: -config="{CheckOptions: {readability-container-size-empty.ExcludedComparisonTypes: '::std::array;::IgnoredDummyType'}}" \
// RUN: -- -fno-delayed-template-parsing -isystem %clang_tidy_headers
#include <string>
@@ -23,7 +23,7 @@
}
namespace string_literals{
-string operator""_s(const char *, size_t);
+string operator""s(const char *, size_t);
}
}
@@ -778,7 +778,7 @@
bool testStringLiterals(const std::string& s)
{
using namespace std::string_literals;
- return s == ""_s;
+ return s == ""s;
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}return s.empty()
}
@@ -786,5 +786,5 @@
bool testNotEmptyStringLiterals(const std::string& s)
{
using namespace std::string_literals;
- return s == "foo"_s;
+ return s == "foo"s;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158691.552947.patch
Type: text/x-patch
Size: 1317 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230824/8d015148/attachment.bin>
More information about the cfe-commits
mailing list