[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added a comment.

> I tried that approach, but found it way too easy to keep `ModuleDeps` around, which keep scanning instances alive, and use tons of memory.

It seems like the problem (too easy to keep around MD) is the same either way, it's just instead of wasting memory it's leaving dangling pointers that could cause UAF if they're actually used.  Where were you seeing MD held too long? I wonder if there's another way to fix that.

> Hmm, maybe we could avoid holding on to the whole CompilerInstance.

This seems promising!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158469/new/

https://reviews.llvm.org/D158469