[clang] ebe82d4 - [Driver] Remove unneeded TargetTriple entry in TripleAliases. NFC

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 23 13:53:40 PDT 2023


Author: Fangrui Song
Date: 2023-08-23T13:53:36-07:00
New Revision: ebe82d4aa6c5223425e27a0eb0157f49701d1057

URL: https://github.com/llvm/llvm-project/commit/ebe82d4aa6c5223425e27a0eb0157f49701d1057
DIFF: https://github.com/llvm/llvm-project/commit/ebe82d4aa6c5223425e27a0eb0157f49701d1057.diff

LOG: [Driver] Remove unneeded TargetTriple entry in TripleAliases. NFC

This logic from 866faab4db1157e1edd2771024aee263367ec1fc (2012) is no
longer needed after D45233 added "Try to match the exact target triple first."

Added: 
    

Modified: 
    clang/lib/Driver/ToolChains/Gnu.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp
index b7fd6208f54204..08bba7b4bd3625 100644
--- a/clang/lib/Driver/ToolChains/Gnu.cpp
+++ b/clang/lib/Driver/ToolChains/Gnu.cpp
@@ -2683,10 +2683,6 @@ void Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes(
     break;
   }
 
-  // Always append the drivers target triple to the end, in case it doesn't
-  // match any of our aliases.
-  TripleAliases.push_back(TargetTriple.str());
-
   // Also include the multiarch variant if it's 
diff erent.
   if (TargetTriple.str() != BiarchTriple.str())
     BiarchTripleAliases.push_back(BiarchTriple.str());


        


More information about the cfe-commits mailing list