[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 23 10:15:22 PDT 2023


yaxunl added inline comments.


================
Comment at: clang/test/Driver/amdgpu-toolchain-opencl.cl:34
+// RUN: %clang -### --target=amdgcn-amd-amdhsa-opencl -Xlinker --unresolved-symbols=ignore-all -x cl -mcpu=fiji -nogpulib %s 2>&1 | FileCheck -check-prefix=CHK-LINK_UR %s
+// CHK-LINK_UR: ld.lld{{.*}} "--unresolved-symbols=ignore-all"
----------------
we need to make sure "--unresolved-symbols=ignore-all" is after "--no-undefined" . same as below


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158582/new/

https://reviews.llvm.org/D158582



More information about the cfe-commits mailing list