[PATCH] D158582: [AMDGPU] Respect unresolved symbol option if forwarded to linker
Joseph Huber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 23 05:57:23 PDT 2023
jhuber6 added a comment.
Remember to clang format.
================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:564-575
+ // If the user has manually passed -Wl,--unresolved-symbols=* as a linker
+ // option, we should not add --no-undefined
+ bool UnresolvedOpt = false;
+ for (auto A : Args)
+ if (A->getOption().matches(options::OPT_Wl_COMMA) ||
+ A->getOption().matches(options::OPT_Xlinker))
+ for (StringRef V : A->getValues())
----------------
A little more concisely.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158582/new/
https://reviews.llvm.org/D158582
More information about the cfe-commits
mailing list