[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

Min-Yih Hsu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 23:16:24 PDT 2023


myhsu added inline comments.


================
Comment at: clang/test/CodeGen/mrtd.c:10
+// X86: call x86_stdcallcc i32 @bar(
+#ifndef mc68000
   bar(arg);
----------------
jrtc27 wrote:
> Uh, this shouldn't be defined in ISO C; GCC's using builtin_define_std, so you should only get `__mc68000` and `__mc68000__` for ISO C, i.e. using `DefineStd("mc68000")` in libClangBasic and let it add the underscored variants needed
Thanks for pointing out. I'll put the changes to using `DefineStd` in a separate patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149867/new/

https://reviews.llvm.org/D149867



More information about the cfe-commits mailing list