[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added a comment.

So while working on D148474 <https://reviews.llvm.org/D148474>  I realized this PR introduced a new crash bug, see the following code: https://godbolt.org/z/h1EezGjbr

  template<typename A3>
  class B3 : A3 {
    template<bool = C3<B3>()>
    B3();
  }; B3(); 
          

which is one of my test cases. I had though it was an interaction between my new code and this but then realized this exists w/o my new code. We can also see from the godbolt above that the crash in this code changed from an assertion to an unreachable. My PR will fix the assertion but I need a good solution to the unreachable bug. I tried changing the unreachable to a `break` but it reduces the quality of the diagnostic and I don't think it is the correct fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139837/new/

https://reviews.llvm.org/D139837